Repository navigation
Conversation
… breakdown The audit user table listed Role, Organization, Scope. Reorder it to Role, Scope, Organization so it reads the same as the role breakdown in the Team Members table. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The user assignments endpoint now returns scope_display_name and no longer returns is_superadmin. Render the scope column with the same ScopeNameCell the team members role breakdown uses, moved to the shared TableCells, so both tables name scopes alike, and drop the unused isSuperadmin field. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…reakdown Render the user assignments role and organization columns with the role badge and the org icon cell the team members breakdown uses, moved to the shared TableCells, so all three columns carry the same icons in both tables. The Super Admin / Global Staff row highlight relied on RoleCell's data-role attribute, so it goes with it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…kground The 11rem floor was scoped to the Team Members collapsed row, so badges in the role breakdown and the user assignments table hugged their label and differed in width. Apply it to the badge itself, and switch its background to gray-100. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The table used auto layout, so each page's content resized the columns. Each column gets a headerClassName and widths follow its proportions from md up: role and organization take 18% and actions 7%, permissions get 16% and the toggle 15%, and scope takes the rest, so every column fits at 1440px. The permissions count stays on one line, and the actions column is centered like the team members one. For small screens keep the auto-sizing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…utton The admin role delete action was a bare Icon with side margins, so it sat off-center in the actions column. Swapping in a disabled IconButton broke the tooltip, since Paragon sets pointer-events: none on disabled icon buttons. DisabledCourseActionButton already worked around that with a hoverable wrapper, so it becomes DisabledActionButton with a tooltip prop and serves the admin role and course-disabled cases alike. Every delete button is size="sm", like the team members view button. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
openedx-webhooks
added
open-source-contribution
|
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #255 +/- ##
==========================================
- Coverage 98.71% 98.68% -0.03%
==========================================
Files 80 80
Lines 1396 1372 -24
Branches 438 459 +21
==========================================
- Hits 1378 1354 -24
Misses 18 18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| Header: getCellHeader('role', formatMessage(messages['authz.user.table.role.column.header']), columnsWithFiltersApplied), | ||
| accessor: 'role', | ||
| Cell: RoleCell, | ||
| Cell: RoleBadgeCell, |
There was a problem hiding this comment.
Figma shows this cell as a simple text not as a badge, Is this modification discussed with the design team?
3 participants
This PR reorganize the columns on the user roles assignments table to match the same order as the subtable in the main page: Role - Scope - Organization.
In addition to the order the PR does:
min-widththe same for all tables.IconButtonfor all the disabled delete actions so it keeps the same icon size as the active action. Centered.>=mdbrackpoint. Small screens keep the auto resize.Closes openedx/openedx-authz#512