Skip to content

style: refine roles & permissions layout - #250

Merged
dcoa merged 2 commits into
masterfrom
jacobo/roles-perm-ui
Oct 12, 2026
Merged

dcoa merged 2 commits into
masterfrom
jacobo/roles-perm-ui

Conversation

@jacobo-dominguez-wgu

@jacobo-dominguez-wgu jacobo-dominguez-wgu commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Description

The roles & permissions view needed visual polish. The courses/libraries toggle and the permission matrix were loosely grouped, the sticky table header had no visual separation from the rows scrolling beneath it, the and some spacing and typography size were modified.

Closes #239
Figma: https://www.figma.com/design/xnmQJq1cTRVqNrs31R8zDM/AuthZ---v2?node-id=40000174-2&p=f&t=8fzWc5on4IFcBybz-0

Note

Some styles differ on the figma and the actual ui ( e.g. the space between the table and its container and the toggle buttons), this is intentional and approved by the designer but this is not reflected on the figma design.

Testing

  • Existing suites for the touched components pass (31 tests across RolesPermissions, PermissionTable, and authz-home).
  • Go to the Roles and permissions tab and verify the ui matches figma design.

Screenshots

Before After
image image

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Oct 8, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @jacobo-dominguez-wgu!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.71%. Comparing base (8c8829a) to head (a61dcfd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #250   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files          80       80           
  Lines        1400     1402    +2     
  Branches      470      472    +2     
=======================================
+ Hits         1382     1384    +2     
  Misses         18       18           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@carlos-marquez-wgu carlos-marquez-wgu left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in my local, looks good, new UI matches figma

Screenshots Image Image

Comment thread src/authz-module/index.scss Outdated
Comment thread src/authz-module/roles-permissions/RolesPermissions.tsx
@dcoa
dcoa merged commit 9f47d93 into master Oct 12, 2026
6 checks passed
@dcoa
dcoa deleted the jacobo/roles-perm-ui branch October 12, 2026 01:24
@openedx-semantic-release-bot

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 1.0.0-alpha.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U released on @latest

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Roles & Permissions tab: selector spacing, button size/color, unified card, header font

5 participants