Repository navigation
style: refine roles & permissions layout - #250
Conversation
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #250 +/- ##
=======================================
Coverage 98.71% 98.71%
=======================================
Files 80 80
Lines 1400 1402 +2
Branches 470 472 +2
=======================================
+ Hits 1382 1384 +2
Misses 18 18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
0e912bb to
09a6595
Compare
|
🎉 This PR is included in version 1.0.0-alpha.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |


Description
The roles & permissions view needed visual polish. The courses/libraries toggle and the permission matrix were loosely grouped, the sticky table header had no visual separation from the rows scrolling beneath it, the and some spacing and typography size were modified.
Closes #239
Figma: https://www.figma.com/design/xnmQJq1cTRVqNrs31R8zDM/AuthZ---v2?node-id=40000174-2&p=f&t=8fzWc5on4IFcBybz-0
Note
Some styles differ on the figma and the actual ui ( e.g. the space between the table and its container and the toggle buttons), this is intentional and approved by the designer but this is not reflected on the figma design.
Testing
RolesPermissions,PermissionTable, andauthz-home).Screenshots