Skip to content

build(konflux): align base image pins with downstream - #6

Closed
Gkrumbach07 wants to merge 1 commit into
mainfrom
codex/align-konflux-base-images
Closed

Gkrumbach07 wants to merge 1 commit into
mainfrom
codex/align-konflux-base-images

Conversation

@Gkrumbach07

@Gkrumbach07 Gkrumbach07 commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Problem

The ODH fork owns deploy/Dockerfile.konflux, but its three base image references are behind the values already used by downstream red-hat-data-services/openshell-dashboard. Independent downstream MintMaker updates then caused the main → rhoai-3.6 sync to conflict on the Go and UBI minimal lines (failed run).

Solution

Bring the ODH Dockerfile's Node, Go, and UBI minimal references to the exact digest-pinned values already present on downstream rhoai-3.6. This keeps the source copy aligned with downstream after downstream PR #25 merges.

Evidence

Merge downstream PR ai-openshell#25 first to clear the current release sync conflict. This PR keeps the ODH source copy aligned afterward.

Summary by CodeRabbit

  • Chores
    • Updated the versions of components used to build and run the application. Existing build stages and application behavior remain unchanged, so this update does not alter user-facing features or workflows.

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: f30bc3ac-7844-4312-8a02-1327e8a8cc0a
Commits

Reviewing files that changed from the base of the PR and between ae76c31 and df4d824.

Files selected for processing: 1
  • deploy/Dockerfile.konflux

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The Dockerfile updates the default tags and pinned digests for the Node.js, Go, and UBI Minimal images. The frontend, backend, and runtime build stages remain unchanged.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: Minimal · up to df4d8

No actionable merge-blocking risk was identified in this base-image alignment change.

Pre-merge checks: Passed 10
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately describes the main change: aligning Konflux base image pins with downstream values.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Contribution Quality And Spam Detection Passed PASS: The PR changes only three digest-pinned base-image declarations in deploy/Dockerfile.konflux. The change is specific to downstream image alignment and does not add security validation, vulnerabi…
No Hardcoded Secrets Passed PASS. The pull request changes only three digest-pinned container image ARGs in deploy/Dockerfile.konflux. The values are registry image references with 64-character hexadecimal SHA-256 digests, not A…
No Weak Cryptography Passed PASS. The pull request changes only three Docker image tags and SHA-256 digest pins in deploy/Dockerfile.konflux. The diff introduces no MD5, SHA-1, DES, 3DES, RC4, Blowfish, ECB mode, custom crypto…
No Injection Vectors Passed PASS. The pull request changes only three hardcoded, digest-pinned Docker image ARG values in deploy/Dockerfile.konflux. It adds no SQL interpolation, shell execution, eval/exec, unsafe deserializatio…
No Privileged Containers Passed PASS. The pull request only changes three digest-pinned base-image ARG values in deploy/Dockerfile.konflux. It does not add privileged, host namespace settings, SYS_ADMIN, `allowPrivilegeEscalat…
No Sensitive Data In Logs Passed PASS. The pull request changes only three digest-pinned Docker base-image ARG values in deploy/Dockerfile.konflux. It adds no logging statements, request/response output, credentials, tokens, or cus…
Full details: Contribution Quality And Spam Detection

Explanation

PASS: The PR changes only three digest-pinned base-image declarations in deploy/Dockerfile.konflux. The change is specific to downstream image alignment and does not add security validation, vulnerability claims, or other code logic. Therefore, no SECURITY THEATER or CODE QUALITY signal is present. The small single-file scope alone cannot fail the check, and no verifiable cross-repository spray evidence is available.

Full details: No Hardcoded Secrets

Explanation

PASS. The pull request changes only three digest-pinned container image ARGs in deploy/Dockerfile.konflux. The values are registry image references with 64-character hexadecimal SHA-256 digests, not API keys, tokens, passwords, private keys, embedded credentials, or base64 strings. No secret-named variable receives a string literal. No CWE-798 hardcoded credential condition is introduced.

Full details: No Weak Cryptography

Explanation

PASS. The pull request changes only three Docker image tags and SHA-256 digest pins in deploy/Dockerfile.konflux. The diff introduces no MD5, SHA-1, DES, 3DES, RC4, Blowfish, ECB mode, custom cryptography, or secret comparisons. No CWE or CVE applies.

Full details: No Injection Vectors

Explanation

PASS. The pull request changes only three hardcoded, digest-pinned Docker image ARG values in deploy/Dockerfile.konflux. It adds no SQL interpolation, shell execution, eval/exec, unsafe deserialization, or dangerouslySetInnerHTML pattern. No CWE-78, CWE-79, CWE-89, CWE-94, or CWE-502 condition is introduced.

Full details: No Privileged Containers

Explanation

PASS. The pull request only changes three digest-pinned base-image ARG values in deploy/Dockerfile.konflux. It does not add privileged, host namespace settings, SYS_ADMIN, allowPrivilegeEscalation, or a root user. The existing USER root at line 22 is unchanged and therefore is not caused by this pull request.

Full details: No Sensitive Data In Logs

Explanation

PASS. The pull request changes only three digest-pinned Docker base-image ARG values in deploy/Dockerfile.konflux. It adds no logging statements, request/response output, credentials, tokens, or customer data exposure. No CWE/CVE applies to the reviewed change.

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant