Hide the ineffective 'Show app icon' setting on Android 10+ - #902
Open
MiMoHo wants to merge 1 commit into
Open
Conversation
…d-team#728) Since Android 10 the platform no longer lets non-system apps hide their own launcher icon: when the only launcher activity is disabled the launcher shows a synthesized entry instead, so the toggle silently does nothing (see openboard-team#728, openboard-team#399). - Remove the preference from the advanced settings screen on API 29+. - On API 29+ always (re-)enable the SetupActivity component in toggleAppIcon(), which also repairs the confusing half-disabled state for users who had turned the icon off before upgrading. - Behaviour on Android 9 and below is unchanged. Fixes openboard-team#728 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Show app icon" toggle in the advanced settings has no visible effect on Android 10+ (#728, #399): since API 29 the platform shows a synthesized launcher entry for apps that disable their only launcher activity, so the icon never actually disappears — the setting is a silent no-op.
Fix
SystemBroadcastReceiver.toggleAppIcon(), always (re-)enable theSetupActivitycomponent on API 29+. This also repairs the confusing half-disabled state for users who had switched the icon off before upgrading their Android version (component disabled + synthesized icon).Testing
Verified on an Android 15 emulator: the "Show app icon" entry no longer appears in Settings → Advanced; the remaining advanced preferences work as before. Builds with the stock toolchain.
Fixes #728
🤖 Generated with Claude Code