fix(hooks): align SessionEnd timeout with Codex runtime cap - #755
Open
james-meneses wants to merge 2 commits into
Open
fix(hooks): align SessionEnd timeout with Codex runtime cap#755james-meneses wants to merge 2 commits into
james-meneses wants to merge 2 commits into
Conversation
Keep the plugin manifest within the runtime teardown budget so loading the lifecycle hook does not emit a clamp warning. Add a regression test that binds the manifest to the three-second runtime ceiling. Authored-By: kyros-architect-harness Dispatch-Id: desktop_sessionend_clamp Refs: openai#474
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Return from session teardown when a broker accepts the shutdown request but never responds. Keep the internal bound below the manifest budget. Authored-By: kyros-architect-harness Dispatch-Id: desktop_sessionend_clamp Refs: openai#755
Author
|
@codex review |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
node --test tests/broker-lifecycle.test.mjs tests/hooks.test.mjs: 2 passnpm test: 93 passhooks/list, before: effectivetimeoutSec: 3plus the clamp warningtimeoutSec: 3,warnings: [],errors: []in two project rootsWhy
The runtime enforces
SESSION_END_MAX_TIMEOUT_SEC = 3to retain headroom inside its five-second app-server shutdown bound. A plugin value of 5 is valid input but is always clamped, producing a warning in every project where the globally enabled plugin is loaded. The prior shutdown request could also wait indefinitely after a broker accepted without replying, so lowering only the manifest value would create a false-green contract.Scope
This bounds the request and removes the manifest/runtime mismatch. It does not change shared-broker ownership or cross-session shutdown policy.
Related: #474, #540, #671