Skip to content

fix(broker): do not signal stale persisted pids - #749

Open
sylvesterkaczmarek wants to merge 1 commit into
openai:mainfrom
sylvesterkaczmarek:fix/broker-pid-reuse
Open

fix(broker): do not signal stale persisted pids#749
sylvesterkaczmarek wants to merge 1 commit into
openai:mainfrom
sylvesterkaczmarek:fix/broker-pid-reuse

Conversation

@sylvesterkaczmarek

Copy link
Copy Markdown

Summary

  • stop treating a PID loaded from persisted broker.json as proof of process ownership
  • require an explicit ownedPid before teardown may signal a process
  • retain the PID fallback for a broker spawned by the current ensureBrokerSession call when startup fails
  • add regressions proving SessionEnd does not signal an unrelated live process after PID reuse

Fixes #743.

Validation

  • npm test (94/94 passed)
  • npm run check-version
  • git diff --check

@sylvesterkaczmarek
sylvesterkaczmarek requested a review from a team September 7, 2026 07:54
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-07T07:58:27.401394Z 9c854bc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SessionEnd kills whatever pid broker.json names, without checking it is still a broker (pid reuse → SIGTERM to an unrelated process group)

1 participant