Skip to content

fix: make runCommand maxBuffer explicit - #747

Open
sylvesterkaczmarek wants to merge 1 commit into
openai:mainfrom
sylvesterkaczmarek:fix/explicit-run-command-buffer
Open

fix: make runCommand maxBuffer explicit#747
sylvesterkaczmarek wants to merge 1 commit into
openai:mainfrom
sylvesterkaczmarek:fix/explicit-run-command-buffer

Conversation

@sylvesterkaczmarek

Copy link
Copy Markdown

Summary

Thanks for the detailed report in #744. This makes the intended buffering behaviour explicit instead of relying on an undefined option overriding Node's 1 MiB spawnSync default.

  • use an explicit 256 MiB default for runCommand
  • preserve smaller caller-provided maxBuffer values used by measurement gates
  • add regressions for output above 1 MiB and for explicit bounded output

Validation

  • npm test (93 passed)
  • node --test tests/process.test.mjs (4 passed)
  • npm run check-version
  • git diff --check

Fixes #744

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-06T22:10:13.287169Z 912e98d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

runCommand sets maxBuffer: options.maxBuffer — the ENOBUFS fix from #179 works only because a spread undefined deletes Node's default

1 participant