Repository navigation
test(visual-skin): give browser fixture launches room for cold starts - #3882
Merged
bobleer merged 1 commit intoNov 12, 2026
Merged
Conversation
The visual-skin browser fixtures launched headless Chromium with a 20 s budget inside a 30 s test. On loaded hosted runners the first cold launch in a file now regularly exceeds that (spawnSync ETIMEDOUT), failing Frontend Build on main and on unrelated PRs. Share one launch budget (60 s) and one test budget (90 s) across the fixtures instead of per-file literals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Give the visual-skin browser fixture tests enough time for a cold headless Chromium launch on loaded CI runners.
Every visual-skin browser fixture launched Chromium with
timeout: 20000inside a 30 s test. On hosted Linux runners the first launch in a file now regularly exceeds that while the full web UI suite runs in parallel, failingFrontend BuildwithspawnSync /usr/bin/chromium ETIMEDOUTorTest timed out in 30000ms. This has failedmainafter #3877/#3879/#3880 merged (run 43127517941) and repeatedly on unrelated PRs (#3878, #3881), always on the first fixture case ofsurface.test.ts/materials.test.ts.The fixtures now share
BROWSER_FIXTURE_LAUNCH_TIMEOUT_MS(60 s) andBROWSER_FIXTURE_TEST_TIMEOUT_MS(90 s) frombrowser-fixture.test-support.tsinstead of per-file literals. Assertions are unchanged.Type and Areas
Type: test / CI
Areas: web UI tests (visual skin)
Motivation / Impact
No direct user-facing change. Unblocks
Frontend Buildonmainand open PRs.Verification
OPENBITFUN_TEST_BROWSER=<Chrome> npx vitest run src/infrastructure/visual-skin --exclude '**/storage.test.ts'insrc/web-ui: 17 files, 134 tests passed with a real browser (storage.test.tsis unchanged; it fails locally for an IndexedDB environment reason with or without this change and passes in CI)tsc --noEmitinsrc/web-uiReviewer Notes
AI-assisted change. This raises budgets rather than changing what is measured; if cold starts keep growing, a shared warm-up launch per file would be the next step.
Checklist