Repository navigation
feat(models): connect Magpie from model settings - #3847
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Magpie as an inline connection in Settings → Models. Detect the gateway, refresh its model catalog, and import selected models into the existing model list; stable model IDs preserve defaults and model-pool references. Existing connections can be edited without dropping models that disappear from the catalog.
Discovery verifies
/api/hellobefore reading/v1/models, distinguishes offline/authentication/catalog failures, and runs on the selected inference host. A negotiatedmagpie_discovery_v1capability gates older peers. Loopback discovery and model requests bypass outbound proxies, while remote endpoints retain the configured proxy policy.Refreshing keeps the current catalog, selection, search and scroll mounted, avoiding the settings-page jump. Includes English, Simplified Chinese and Traditional Chinese copy.
Validation
Physical Peer Device, SSH, Remote Control and Detached Dispatch scenarios were not exercised; peer routing and unsupported-host behavior are covered by fixtures.