Repository navigation
[py-libpysal] Depend on py-beautifulsoup4 - #306
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libpysal requires beautifulsoup4 (
beautifulsoup4>=4.13.0) and imports it inlibpysal.examples, whichimport libpysalloads. The port didn't declare it, so it only built when py-beautifulsoup4 happened to be installed first. Otherwise its import test fails withModuleNotFoundError: No module named 'bs4'. The other requirements in libpysal's metadata are already declared.Tested on an arm64 Mac, cross-building
x64-osx-dynamic-releasewith the #299/#300/#302 stack: with bs4 removed, installing only py-libpysal builds py-beautifulsoup4 first, and libpysal and pysal import. That tree also had #305 (soupsieve), but this PR doesn't depend on it.