Repository navigation
Conversation
…r when cross-compiling
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #297, so merge that one first. Only the last two commits are new here.
vcpkg-python-scriptsis a host dependency, but itsPYTHON3is the target interpreter (${CURRENT_INSTALLED_DIR}/tools/python3). When host and target triplets are the same, the hostpython3dependency covers it. In a cross build, nothing orders apy-*port after the targetpython3. vcpkg can then build the port first, and it fails with:This hit py-packaging in both clean cross builds I ran with #297. A rerun succeeded once python3 was installed.
104
py-*ports already listpython3as a dependency. This PR adds it to the 16 that don't and bumps theirport-version:py-annotated-types, py-certifi, py-cppy, py-kiwisolver, py-packaging, py-pillow, py-pyproject-metadata, py-scikit-build-core, py-semantic-version, py-setuptools-scm, py-sip, py-six, py-tomli, py-typing-extensions, py-typing-inspection, py-wheel
When host and target triplets are the same, as in this repository's CI, the new dependency is the
python3package that is already installed. Only the ABI hashes change.Tested on an arm64 macOS host with the
x64-osx-dynamic-releasetarget, as in #297. I removed python3 and allpy-*ports, then ran onevcpkg installof py-pyqt6 and py-pyqt6-webengine. vcpkg now installs python3:x64 before py-packaging:x64, and the build succeeds on the first run. Of the 16 ports, that build includes py-packaging, py-sip and py-wheel; the other 13 were not built. I ran the static workflow's version-database and manifest-format checks locally, and both pass.