Repository navigation
Remove unused private JNI signature machinery - #58
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
brotskydotcom
approved these changes
Nov 3, 2026
brotskydotcom
left a comment
brotskydotcom
left a comment
Contributor
There was a problem hiding this comment.
I suspect the original author was reusing code from a different context. It makes everything a lot harder to read to have these cases that aren't used. Nice fix.
LucaCappelletti94
force-pushed
the
coverage/jni-scope
branch
from
November 8, 2026 21:20
d80afae to
bd64761
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JNI method calls build signatures as strings, leaving the private
ReturnTypeconversion and several signature variants unused. Javavoidresults arrive asJValueGen::Void, so()needs nonullconversion.