Skip to content

Validate the supplied store divider - #56

Merged
LucaCappelletti94 merged 1 commit into
mainfrom
coverage/config-validation
Nov 8, 2026
Merged

LucaCappelletti94 merged 1 commit into
mainfrom
coverage/config-validation

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Collaborator

On main, divider parsing checks the default divider instead of the supplied value. Empty and alphanumeric dividers therefore pass configuration parsing and fail only when the vault is opened.

@LucaCappelletti94 LucaCappelletti94 added the bug Something isn't working label Oct 25, 2026
@codecov

codecov Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@brotskydotcom brotskydotcom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catches.

@LucaCappelletti94
LucaCappelletti94 force-pushed the coverage/config-validation branch from 6f4626e to b9e0131 Compare November 8, 2026 21:36
@LucaCappelletti94
LucaCappelletti94 merged commit 47f9286 into main Nov 8, 2026
14 checks passed
@LucaCappelletti94
LucaCappelletti94 deleted the coverage/config-validation branch November 8, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants