dashboard: enable keyboard activation of dashboard items (fixes #10248) - #10253
dashboard: enable keyboard activation of dashboard items (fixes #10248)#10253RyanS4 wants to merge 2 commits into
Conversation
|
Warning Review limit reached
Next review available in: 26 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: QUIET Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughDashboard tiles now support keyboard activation and router-based item navigation. Navigation skips missing-link or recently dragged items, normalizes links, and preserves optional return state. ChangesDashboard tile navigation
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant User
participant DashboardTileComponent
participant ActivatedRoute
participant Router
User->>DashboardTileComponent: Press Enter or Space on a dashboard item
DashboardTileComponent->>DashboardTileComponent: Check item link and recent drag state
DashboardTileComponent->>ActivatedRoute: Use current route for relative navigation
DashboardTileComponent->>Router: Navigate with normalized link and optional return state
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/app/dashboard/dashboard-tile.component.html`:
- Around line 38-39: Prevent delete-button keyboard events from reaching the
tile’s key handlers by updating the delete button’s keydown handling, covering
both Enter and Space while preserving its deletion behavior. Use event
propagation control or target/currentTarget filtering so the tile’s
navigateToItem handler is never invoked, and add keyboard coverage for both
keys.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 0eb5984c-5100-420c-becd-bb380c647bfc
📒 Files selected for processing (2)
src/app/dashboard/dashboard-tile.component.htmlsrc/app/dashboard/dashboard-tile.component.ts
Fixes #10248
Summary by CodeRabbit
New Features
Bug Fixes