all: Readd one-var lint rule (connects #9082)

[paulbert]

Now I got my local model working (Qwen3.5: a3b-35b-Q4).

This rule seems to be a bit more of a preference than anything else. It'd be good to keep things consistent, and since the change to switch to the "never" variant is minimal I think we should use this instead of "always".

LLM output:
Added one-var: ["error", "never"] rule and auto-fixed all 8 lint errors.

connects #9082

Summary by CodeRabbit

• Refactor
  • Standardized variable declarations across application code and tests.
  • Improved code consistency by requiring each variable declaration to be written separately.
  • No user-facing behavior or functionality changed.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f56627b5-3b25-40b3-b54e-74f6e06c6e84

📥 Commits

Reviewing files that changed from the base of the PR and between 6c3ea09 and 84e4ca2.

📒 Files selected for processing (9)

• .eslintrc.json
• eslint.config.mjs
• src/app/courses/courses.component.ts
• src/app/home/home.component.spec.ts
• src/app/login/login.component.spec.ts
• src/app/manager-dashboard/sync.directive.ts
• src/app/resources/resources.component.ts
• src/app/shared/forms/planet-tag-input-dialog.component.ts
• src/app/validators/custom-validators.ts

---

📝 Walkthrough

Walkthrough

The ESLint one-var rule now requires separate variable declarations. Combined declarations were split in affected application and test files without changing runtime behavior.

Changes

Separate variable declaration enforcement

Layer / File(s)	Summary
Enable one-var enforcement .eslintrc.json, eslint.config.mjs	Both ESLint configurations now require separate variable declarations.
Split combined declarations src/app/courses/..., src/app/home/..., src/app/login/..., src/app/manager-dashboard/..., src/app/resources/..., src/app/shared/forms/..., src/app/validators/...	Combined declarations are replaced with separate let or const statements in application code and test setup.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• open-learning-exchange/planet#10245: Both PRs update ESLint configuration and apply lint-driven declaration fixes.

Suggested reviewers: mutugiii

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the reintroduction of the one-var lint rule, which is the main change in the pull request.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 9082-one-var

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}