Repository navigation
Conversation
sunxiuguo
marked this pull request as ready for review
October 22, 2026 16:57
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to omdsh-dev/dsh-genui#354 and the scoped direction in omdsh-dev/dsh-genui#354 (comment) . This is the BetterSidebar provider half, targeting
dev; the scoped real dual-plugin workflow is now validated on the exact rc.2 source-layout web host; the separate Sidebar repository gates below are not claimed complete.Validation completed
pnpm typecheck,pnpm build, and package creation passed in the isolated source copy.devand this candidate under a normal fresh owned HOME produced 65 passed / the same 6 Git-history failures on each, with the media-path case passing on both. No assertions or production behavior were relaxed.Real dual-plugin acceptance completed
The exact current provider head
34fbad8a75ca4e80af0375800378bcf7c4119d1dwas built with the repository-pinned pnpm 11.8.0 and normal frozen install/typecheck/build/pack in both Node 22 and 24 lanes of GenUI run 39816456694, at GenUI headdbc6cc73aecf70f2b26875c759511837b803c66d. That run completed 6/6 jobs successfully. Both exact packs were installed normally into the real rc.2 host; 475 installed Sidebar package files matched their packed bytes in each lane.Both real browser lanes verified 12 independent main/A/B form values, original text blocks 0/2 and fence indexes 0/1, native tab and conversation away/return, and button plus submit in each owning child. Four HTTP responses complete successfully and exact payloads settle durably in the correct children only. Parent and both away sessions remain unchanged through a 1-second quiet window; four replay calls consume both scripts and cleanup completes. Safe JSON receipts and synthetic element screenshots were independently reviewed. This closes the scoped dual-plugin acceptance gap, not merely a jsdom or backend rehearsal.
The provider's restored-history correction is included in the pinned head: only an inherited seed boundary cuts ancestor history; an ordinary restore does not discard this child's original surface. Its targeted regressions and the real native-switch/action flow above cover the reported case.
Remaining independent CI checks and limits
Sidebar's own workflow remains
action_required; the full-history test suite and dedicatedplugin-mount/ native-reload / editor / terminal / search-engine gates still need that normal maintainer-authorized run. The previously disclosed source-copy failures above are not called all green, and GenUI's dual-plugin result does not substitute for those distinct repository checks. This is ready for review, not a request to waive CI or merge automatically.The real acceptance uses synthetic data and keyless replay on exact rc.2 web, not live model traffic, rc.1-specific mount coverage, or DSH Desktop/native-link validation. No release is requested.