Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #995
When spawning an fd/rg probe throws synchronously,
verify()callsfinish(false)before itsconst timerhas initialized. Cleanup then throwsCannot access 'timer' before initialization, rejecting the cached engine probe and preventing file search from reaching its plain-walk fallback.Initialize the optional timer before that failure path becomes reachable. Keep its allocation after a successful spawn. A regression test forces synchronous spawn failures, verifies that
searchFiles()still returns an actual matching file via the plain walk, and checks that the cached probe resolves to an empty engine list. The test reproduced the reported ReferenceError before the fix and passes afterward.Validation:
\n.GET /open-in-app/icon/filemanager → 404in WSL; all preceding blank-session behavior assertions pass. Its network trace contains only that failing resource. This was independently reproduced in a host-only profile without Better Sidebar during the earlier local verification; neither host source nor the console assertion was changed.Kept as a draft because the standard mount gate is not fully green in this local WSL environment. Physical macOS hardware was not exercised; the reported ReferenceError was reproduced through the synchronous-spawn-failure regression above.