Repository navigation
Fix three build crashes: non-string titles, footnotes in headings, raster favicons - #425
Merged
Merged
Conversation
…ster favicons - index.11tydata.js: coerce note titles to strings before sorting/comparing, so a numeric or date title no longer crashes the front page. - utils.js: render heading inline tokens with state.env so markdown-it-footnote finds env.docId when a heading contains a footnote. - normalize-favicon.js: detect PNG/JPEG/GIF/WebP saved as favicon.svg and wrap them in an SVG with a data URI instead of failing the build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017iXNomAvG3sXxCWaNSgNqZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three template bugs that failed garden builds during the 1.92.x fork sync:
src/site/index.11tydata.js): a title like2024or a YAML date isn't a string, so the title comparison threw. Titles are now coerced withString(...).src/helpers/utils.js):namedHeadingsrendered the heading's inline tokens withoutstate.env, so markdown-it-footnote couldn't readenv.docId. The heading is now rendered with the real env.favicon.svgcrashes the build (src/site/normalize-favicon.js): raster images are now detected by their magic bytes (PNG, JPEG, GIF, WebP) and wrapped in an SVG with a data URI instead of being parsed as SVG.