chore(W-22515355): upgrade to typescript 6 - #1641
Merged
Merged
Conversation
Bump typescript devDependency ^5 -> ^6.0.3. Set explicit module/moduleResolution: nodenext across tsconfigs and test fixtures, and switch rootDirs -> rootDir, as required by the stricter TS 6 defaults.
jfeingold35
reviewed
Aug 27, 2026
| "compilerOptions": { | ||
| "outDir": "./lib", | ||
| "rootDirs": ["./src"] | ||
| "rootDirs": ["./src"], |
Contributor
There was a problem hiding this comment.
Why didn't the rootDirs property in this and the others need to change to rootDir like the top-level one did?
Contributor
Author
There was a problem hiding this comment.
I am not sure. I suspect it's because it doesn't really matter. Claude changed the top-level one and it made sense so I left it. But whether it's rootDirs with an array of one or rootDir with a string doesn't make a difference.
jfeingold35
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrades the dev toolchain to TypeScript 6. Specifically:
typescriptdevDependency from^5to^6.0.3.module/moduleResolution: nodenextacross the root/test tsconfigs and all test fixtures, as required by TS 6's stricter defaults.rootDirs: ["./src"]torootDir: "./src"in the root tsconfig.Repro
Manual testing is not applicable for this change — it's a dev-tooling upgrade covered by the existing build and automated test suite. To verify:
yarn installyarn build— compiles cleanly under TypeScript 6.yarn test— existing unit/integration tests pass.What issues does this PR fix or reference?
@W-22515355@