Experimental: stabilize MEI intrinsics optimization - #103
Draft
heiwang1997 wants to merge 2 commits into
Draft
heiwang1997 wants to merge 2 commits into
heiwang1997 wants to merge 2 commits into
Conversation
Signed-off-by: Jiahui Huang <jiahuih@nvidia.com>
Signed-off-by: Jiahui Huang <jiahuih@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This experimental PR investigates stabilizing MEI intrinsics optimization on a two-sequence Brown/OpenCV
k1=-0.3benchmark.It includes three default-path correctness fixes:
It also adds default-off experimental controls:
All experimental options default to the existing behavior.
Evaluation
On two 180-frame sequences:
The strict result reproduced across seeds 0/1/2. With default stochastic initialization and reductions, live ATE remained basin-sensitive (
156.0 / 8.5 / 152.7 mm).This is not evidence that MEI accurately represents Brown distortion: optimized xi remains large, and a true Brown/OpenCV camera model is still the appropriate long-term solution.
Experimental configuration
Strict deterministic evaluation additionally used
CUBLAS_WORKSPACE_CONFIG=:4096:8before importing PyTorch andtorch.use_deterministic_algorithms(True).Validation
pytest -q: 102 passedruff check .: passedmypy: passedmkdocs build --strict: passed3.6e-15Scope
This is experimental infrastructure for reproducing and studying the benchmark. It does not add a Brown/OpenCV camera model, and the experimental optimizer settings should not be promoted to defaults based on these two sequences.