Remove pairing/bonding from the app - #17
Merged
Merged
Conversation
Adds unnecessary friction to the quickstart flow, remove it with warnings sprinkled about why this is bad practice for real apps.
noahp
marked this pull request as ready for review
August 12, 2026 17:24
gminn
approved these changes
Aug 12, 2026
| ## App behavior to preserve | ||
|
|
||
| - **No pairing/bonding:** `CONFIG_BT_SMP=n` — this sample has no encryption or bonding. A | ||
| real product handling sensitive data should set `CONFIG_BT_SMP=y` and use bonding |
There was a problem hiding this comment.
Maybe we should add this to the list of configs listed at https://docs.memfault.com/docs/mcu/mds#restricting-access and add a link to that doc here
Collaborator
Author
There was a problem hiding this comment.
ah, great idea, did it!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unnecessary friction to the quickstart flow, remove it with
warnings sprinkled about why this is bad practice for real apps.