fix(websocket): preserve handshake failure message#5366
Closed
marko1olo wants to merge 1 commit into
Closed
Conversation
Store the WebSocket failure reason on the handler so the emitted ErrorEvent exposes a non-empty TypeError message while keeping the close event reason tied to the close frame. Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: marko1olo <barsukdana@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4735.
Refs #4625.
Rationale
Failed WebSocket handshakes already pass a useful failure reason into
failWebsocketConnection(), but the laterErrorEventwas built from the close-frame reason. For handshake failures there is no close-frame reason, soevent.error.messagewas empty.Changes
TypeErrorfrom the stored failure reason while leavingCloseEvent.reasontied to the actual close frame.1006unchanged.Tests
npx borp --timeout 180000 -p "test/websocket/issue-4735.js"npm run lint -- --no-cache lib/web/websocket/connection.js lib/web/websocket/websocket.js test/websocket/issue-4735.jsnpx borp --timeout 180000 -p "test/websocket/events.js"npx borp --timeout 180000 -p "test/websocket/issue-3506.js"npx borp --timeout 180000 -p "test/websocket/issue-3546.js"git diff --check HEAD~1 HEADI also tried broader local websocket coverage, but
npm run test:websockettimed out after 5 minutes andtest/websocket/opening-handshake.jstimed out locally before producing a result.This change was prepared with OpenAI Codex.