Skip to content

[node-projects/web-component-designer#464] unit editor addons - #482

Draft
jogibear9988 wants to merge 3 commits into
masterfrom
ai/node-projects/web-component-designer-464-unit-editor-addons-2
Draft

[node-projects/web-component-designer#464] unit editor addons#482
jogibear9988 wants to merge 3 commits into
masterfrom
ai/node-projects/web-component-designer-464-unit-editor-addons-2

Conversation

@jogibear9988

Copy link
Copy Markdown
Member

Ticket: #464

AI summary

Implemented staged unit-editor addon support in web-component-designer.

Implementation evidence

Properties can now provide unitEditorAddon, which receives current value/selection plus commit and preview callbacks and returns a control hosted beside the numeric unit editor. Public addon types are exported; a regression test covers configuration propagation. Demo repository unchanged.

Independent completion audit

Passed: Staged implementation satisfies the ticket: CSS unit properties can supply a custom control beside the numeric unit editor, suitable for a rotation-style popup/control.

Checklist verified: (1) generic special-unit addon contract: IProperty exposes unitEditorAddon and public UnitEditorAddon/UnitEditorAddonContext types are exported; (2) propagation: getCssNumericEditorConfig carries the property addon into the runtime unit-editor config; (3) runtime hosting: UnitPropertyEditor creates the addon and assigns it to NumericStyleInput, whose addon container is rendered beside input, unit selector, and stepper; (4) integration: context exposes current value and design items plus commit, preview, and preview-removal callbacks routed through the existing property-service/undo and CSS !important proxy paths; (5) compatibility: absent addons leave the existing unit-editor paths unchanged. The supplied screenshots establish the requested rotation-popup use case; the implementation intentionally provides the reusable extension point rather than hard-coding a rotation control. Searches found no stale/alternate unit-editor configuration path or old repurposed field needing migration. Staged diff is limited to the six claimed library/test files and git diff --check reports no whitespace errors.

Validation

Agent-reported required validation: passed.

Ran npm run build successfully, then npm test -- --runInBand: 13 suites and 118 tests passed. Initial test run required building generated dist imports first. Staged only the six intentional library/test files; cached diff check passed.

No application-controlled validation commands configured.

Created automatically as a draft for human review.

@jogibear9988

Copy link
Copy Markdown
Member Author

not only add the possibility, also add a addon directly for angles, as shown in the screenshots

@jogibear9988

Copy link
Copy Markdown
Member Author

[AI Ticket Worker] Addressed in the latest update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant