Repository navigation
docs(agent keys): drop leftover mentions of the Claude app's chat side - #114
Merged
Merged
Conversation
Since ADR-0013 step 3 (#113) the key route answers only Claude Code (including the Claude app's Code tab) and the Codex command-line tool, and the setup script no longer prints a Claude app chat config. Three lines still named the Claude app as if its chat side were a client: - docs/agent-keys.md, removing the setup: delete the tool from ~/.codex/config.toml, not from a "Claude app config". - docs/agent-keys.md, status: "from Claude Code (in Terminal or the Claude app's Code tab) or Codex". - crates/agent-keys-mcp/src/lib.rs, a doc comment on client timeouts: only Codex is named now. No code change. ADR-0012 keeps its original wording; ADR-0013 narrows it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up to #113: three lines still talked about the Claude app's chat side as if it could use the agent key route.
Since ADR-0013 step 3, the route answers only Claude Code (including the Claude app's Code tab) and the Codex command-line tool. The setup script also stopped printing a Claude app chat config. These lines didn't catch up:
docs/agent-keys.md, "To remove the setup": said to delete the tool's lines from "the Codex or Claude app config". It now says to runclaude mcp remove --scope user enote-keys, or to delete the[mcp_servers.enote-keys]lines from~/.codex/config.toml.docs/agent-keys.md, status note: said nobody had used the route "from Claude Code, Codex or the Claude app". It now says "from Claude Code (in Terminal or the Claude app's Code tab) or Codex".crates/agent-keys-mcp/src/lib.rs, doc comment on client timeouts: named "Codex and the Claude app". It now names only Codex. This is a comment change; no code changed.ADR-0012 still says "Claude Code, the Claude app or Codex". I left it as written because it records the original decision, and ADR-0013 narrows it.
Checks:
cargo fmt --check -p agent-keys-mcpand the secret scan pass. No links changed.🤖 Generated with Claude Code