Restore aria attributes after a highlight - #622
Merged
Merged
Conversation
The highlight overwrites aria-controls, aria-expanded, and aria-haspopup. The previous values are written back when the highlight moves on and when the tour is destroyed. Fixes nilbuild#495
Owner
|
Thanks! I made the helper code a bit shorter and added one more test before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Highlight keeps the element's previous
aria-controls,aria-expanded, andaria-haspopup, then writes them back when the highlight moves on and when the tour is destroyed. During the step the element still points atdriver-popover-content.Test plan
pnpm test:run(341 passed)pnpm buildpnpm lint:packageFixes #495