-Issue#212: Adding more machine translation alternatives - #247
Open
rupeshkumaar wants to merge 5 commits into
Open
rupeshkumaar wants to merge 5 commits into
rupeshkumaar wants to merge 5 commits into
Conversation
nidhaloff
requested changes
Oct 28, 2023
nidhaloff
left a comment
nidhaloff
left a comment
Owner
There was a problem hiding this comment.
Thanks for the PR. I added some comments.
Also can you please add the new translators on the README
Author
|
Added the translations to README. |
Owner
|
@rupeshkumaar I approved your PR but The tests are failing. Can you check it out or maybe rebase/merge your branch with the latest of master |
Author
@nidhaloff the branch is up to date with the master branch. So, it does not seem to do anything with that. It said poetry installation failed in one of the tests. Can you please check that? |
Author
|
Please review now and merge @nidhaloff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have worked on #212: Adding more machine translation alternatives (Glosbe & Wikimedia MinT)
Please review and merge: @nidhaloff