Skip to content

Bump Go toolchain to 1.26.7 to remediate standard-library CVEs (dev-v2) - #1894

Merged
ShubhenduSinghF5 merged 1 commit into
nginx:dev-v2from
ShubhenduSinghF5:ss-go-toolchain-1.26.7
Aug 21, 2026
Merged

Bump Go toolchain to 1.26.7 to remediate standard-library CVEs (dev-v2)#1894
ShubhenduSinghF5 merged 1 commit into
nginx:dev-v2from
ShubhenduSinghF5:ss-go-toolchain-1.26.7

Conversation

@ShubhenduSinghF5

@ShubhenduSinghF5 ShubhenduSinghF5 commented Aug 21, 2026

Copy link
Copy Markdown

Proposed changes

Bumps the Go toolchain directive from go1.26.5 to go1.26.7 in both go.mod and sdk/go.mod.

This is the CVE-remediation change for the 2.46.8 release. It resolves 7 code-reachable Go standard-library CVEs (net/url, html/template, crypto/tls ×2, net/http ×2, encoding/xml, encoding/asn1) reported by govulncheck:

CVE ID Package Fixed in
GO-2026-6218 net/url go1.26.6
GO-2026-6091 html/template go1.26.6
GO-2026-6090 crypto/tls go1.26.6
GO-2026-6089 net/http go1.26.6
GO-2026-6088 encoding/xml go1.26.6
GO-2026-5972 encoding/asn1 go1.26.6
GO-2026-5026 net/http (idna) go1.26.6

Alternative to #1884 (which bumps to 1.27.0). 1.27.0 fixes the same CVEs but additionally breaks CI — golangci-lint (v2.10.1, built with Go 1.26) refuses to run against a 1.27 target, and the SDK zip-checksum tests fail (Go 1.27 changed the gzip encoder output; contents unchanged). 1.26.7 delivers the full CVE fix with zero collateral breakage. Reserving 1.27.0 (#1884) for 2.47.0.

Verified locally: go build ./... OK; SDK tests pass; govulncheck -scan=symbol under go1.26.7 reports "No vulnerabilities found."

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

Resolves 8 code-reachable Go standard-library CVEs (net/url, html/template, crypto/tls, net/http, encoding/xml, encoding/asn1) reported by govulncheck. Verified: govulncheck reports 'No vulnerabilities found' under go1.26.7 and SDK tests pass. Alternative to nginx#1884 (1.27.0), which additionally breaks golangci-lint and SDK checksum tests; reserving 1.27.0 for 2.47.0.
@ShubhenduSinghF5
ShubhenduSinghF5 requested a review from a team as a code owner August 21, 2026 15:26
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (dev-v2@c586af6). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             dev-v2    #1894   +/-   ##
=========================================
  Coverage          ?   52.24%           
=========================================
  Files             ?       51           
  Lines             ?     3518           
  Branches          ?        0           
=========================================
  Hits              ?     1838           
  Misses            ?     1534           
  Partials          ?      146           

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c586af6...2090ab8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@balakoteswar
balakoteswar self-requested a review August 21, 2026 15:48
@ShubhenduSinghF5
ShubhenduSinghF5 merged commit 6e84399 into nginx:dev-v2 Aug 21, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants