Repository navigation
fix(user): Fix grammar in the invalid login characters message - #66842
Open
rakekniven wants to merge 1 commit into
Open
rakekniven wants to merge 1 commit into
rakekniven wants to merge 1 commit into
Conversation
"an Login" -> "a Login". Reported at Transifex. Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rakekniven
requested review from
artonge and
marcoambrosini
and removed request for
a team
November 19, 2026 20:02
kesselb
approved these changes
Nov 19, 2026
kesselb
left a comment
Contributor
There was a problem hiding this comment.
Thanks 👍
A bit weird though, that the file mixes Login and Username 🤷
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A translator reported at Transifex a grammar error in the source string of
validateUserId(): "Only the following characters are allowed in an Login: …" → "… in a Login: …".The other messages in the same function also use "Login" ("A valid Login must be provided", "Login contains whitespace …"), so only the article changes.
ManagerTest::testCreateUserInvalid()only checks the exception type, so no test change is needed.Checklist
🤖 Generated with Claude Code