Repository navigation
fix(app): Say "PHP %s or lower" for the max-version check - #66838
Open
rakekniven wants to merge 1 commit into
Open
rakekniven wants to merge 1 commit into
rakekniven wants to merge 1 commit into
Conversation
The max-version check only fails when the installed PHP version is greater than the maximum (version_compare with ">"), so the maximum itself is accepted. "lower than %s" was wrong. Use the same wording as "Server version %s or lower is required." Reported at Transifex. Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rakekniven
requested review from
CarlSchwan and
icewind1991
and removed request for
a team
November 19, 2026 20:00
icewind1991
approved these changes
Nov 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A translator reported at Transifex that "PHP with a version lower than %s is required." does not match the check.
analyzePhpVersion()only reports the max-version whencompareBigger($phpVersion, $maxVersion)is true, i.e.version_compare(…, '>'). The maximum version itself is accepted (and withnormalizeVersions()a max of8.3also accepts8.3.12). So "lower than 8.3" is wrong; "8.3 or lower" is right and matches the existing "Server version %s or lower is required."This PR changes the message to "PHP %s or lower is required." and updates
DependencyAnalyzerTest.Note: the library messages ("Library %1$s with a version higher/lower than %2$s is required …") have the same off-by-one wording; not changed here.
Checklist
🤖 Generated with Claude Code