Skip to content

fix(app): Say "PHP %s or lower" for the max-version check - #66838

Open
rakekniven wants to merge 1 commit into
masterfrom
fix/l10n-php-max-version-message
Open

rakekniven wants to merge 1 commit into
masterfrom
fix/l10n-php-max-version-message

Conversation

@rakekniven

Copy link
Copy Markdown
Member

Summary

A translator reported at Transifex that "PHP with a version lower than %s is required." does not match the check.

analyzePhpVersion() only reports the max-version when compareBigger($phpVersion, $maxVersion) is true, i.e. version_compare(…, '>'). The maximum version itself is accepted (and with normalizeVersions() a max of 8.3 also accepts 8.3.12). So "lower than 8.3" is wrong; "8.3 or lower" is right and matches the existing "Server version %s or lower is required."

This PR changes the message to "PHP %s or lower is required." and updates DependencyAnalyzerTest.

Note: the library messages ("Library %1$s with a version higher/lower than %2$s is required …") have the same off-by-one wording; not changed here.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included

🤖 Generated with Claude Code

The max-version check only fails when the installed PHP version is
greater than the maximum (version_compare with ">"), so the maximum
itself is accepted. "lower than %s" was wrong. Use the same wording as
"Server version %s or lower is required." Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rakekniven
rakekniven requested a review from a team as a code owner November 19, 2026 20:00
@rakekniven
rakekniven requested review from CarlSchwan and icewind1991 and removed request for a team November 19, 2026 20:00

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants