Skip to content

fix(files_sharing): Add translator context for the expire date error - #66836

Open
rakekniven wants to merge 1 commit into
masterfrom
fix/l10n-share-expire-date-context
Open

rakekniven wants to merge 1 commit into
masterfrom
fix/l10n-share-expire-date-context

Conversation

@rakekniven

Copy link
Copy Markdown
Member

Summary

A translator asked at Transifex whether "Invalid date. Format must be YYYY-MM-DD" is shown to web users, since French UIs display dates as DD/MM/YYYY. The current French translation changed the format to "JJ-MM-AAAA", which would tell API users to send day-month-year.

The message is thrown by parseDate() when the expireDate parameter of the share API cannot be parsed. The web UI always sends YYYY-MM-DD (formatDateToString() in SharesMixin.js), so the message mainly reaches API clients. This PR adds a TRANSLATORS comment that says so and asks to keep the order. No string changes.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits

🤖 Generated with Claude Code

Translators asked at Transifex whether YYYY-MM-DD is a display format.
It is the format the share API expects for expireDate.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rakekniven
rakekniven requested a review from a team as a code owner November 19, 2026 16:19
@rakekniven
rakekniven requested review from GhassenKefi and pabzm and removed request for a team November 19, 2026 16:19

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants