Repository navigation
[WIP] test(files_external): cover shared SFTP client use during reads - #66787
Draft
joshtrichards wants to merge 4 commits into
Draft
joshtrichards wants to merge 4 commits into
joshtrichards wants to merge 4 commits into
Conversation
Exercise an uncached stat on the same SFTP client while a read stream remains open, both immediately after opening and after an initial read. Verify that the stat succeeds and the stream returns the full response. Assisted-by: Copilot:gpt-6.1-sol Signed-off-by: Josh <josh.t.richards@gmail.com>
Request and consume each read chunk within stream_read() instead of prefetching during open, seek, or after a read. This prevents other operations on the shared client from consuming a pending DATA response as their own, as reproduced by the SFTP integration tests against OpenSSH. Keep the remote handle and 256 KiB buffering, but remove pending-read tracking and response draining during seek and close. Propagate send failures rather than attempting to receive after an unsuccessful send. This removes overlap between remote fetching and caller consumption, not an additional round trip per chunk. Fast consumers should see limited impact, but... And performance has not been real-world benchmarked. Assisted-by: Copilot:gpt-6.1-sol Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
masterthis should fail, at least against OpenSSH.tests/Storage/but also not specified to run in the live SFTP server test runs; the entire contents oftests/Storageis also excluded from being ran by the non-live SFTP runs. A broader/cleaner bit of tidying will likely require a follow-up.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)