Skip to content

feat(ocm): support new format of notfication payload - #66628

Open
cristianscheid wants to merge 1 commit into
masterfrom
feat/noid/ocm-new-notifications-provider
Open

cristianscheid wants to merge 1 commit into
masterfrom
feat/noid/ocm-new-notifications-provider

Conversation

@cristianscheid

@cristianscheid cristianscheid commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

Summary

This PR was created in favor of #66049. With this PR, instead of using only OCMNotificationReceivedEvent to deal with a received notification, a ICloudFederationProvider is used instead, more similar to the existing pattern/architecture.

TODO

  • add tests

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@cristianscheid cristianscheid self-assigned this Nov 15, 2026
@cristianscheid
cristianscheid force-pushed the feat/noid/ocm-new-notifications-provider branch 4 times, most recently from 2769cc1 to 73aaba9 Compare November 15, 2026 11:55
@mickenordin

mickenordin commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

I think there are multiple conceptual issues with the provider pattern.

Currently the provider only dispatches on resourceType. But not all notifications have a resourceType. Also if you try to add multiple providers for the same resourceType, it will just use the last I think.

There are alot of other ways you will want to dispatch notifications, for example shareType and notificationType. Having an event is much more flexible in this manner. If we want to stick with the provider pattern, it needs to dispatch on alot more that just the resourceType at the very least a combination of resourceType, shareType and notificationType.

@cristianscheid
cristianscheid force-pushed the feat/noid/ocm-new-notifications-provider branch 3 times, most recently from 253c72c to 4a7d14f Compare November 17, 2026 12:34
@cristianscheid
cristianscheid force-pushed the feat/noid/ocm-new-notifications-provider branch 2 times, most recently from b154af7 to f2d35b4 Compare November 19, 2026 21:24
@cristianscheid
cristianscheid marked this pull request as ready for review November 19, 2026 21:43
@cristianscheid
cristianscheid requested review from icewind1991 and removed request for a team November 19, 2026 21:43
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
@cristianscheid
cristianscheid force-pushed the feat/noid/ocm-new-notifications-provider branch from f2d35b4 to a431a3a Compare November 19, 2026 21:44

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants