Repository navigation
feat(ocm): support new format of notfication payload - #66628
Open
cristianscheid wants to merge 1 commit into
Open
cristianscheid wants to merge 1 commit into
cristianscheid wants to merge 1 commit into
Conversation
cristianscheid
force-pushed
the
feat/noid/ocm-new-notifications-provider
branch
4 times, most recently
from
November 15, 2026 11:55
2769cc1 to
73aaba9
Compare
2 of 7 tasks
Contributor
|
I think there are multiple conceptual issues with the provider pattern. Currently the provider only dispatches on There are alot of other ways you will want to dispatch notifications, for example |
cristianscheid
force-pushed
the
feat/noid/ocm-new-notifications-provider
branch
3 times, most recently
from
November 17, 2026 12:34
253c72c to
4a7d14f
Compare
3 of 7 tasks
cristianscheid
force-pushed
the
feat/noid/ocm-new-notifications-provider
branch
2 times, most recently
from
November 19, 2026 21:24
b154af7 to
f2d35b4
Compare
cristianscheid
marked this pull request as ready for review
November 19, 2026 21:43
cristianscheid
requested review from
a team,
nickvergessen and
provokateurin
as code owners
November 19, 2026 21:43
cristianscheid
requested review from
icewind1991
and removed request for
a team
November 19, 2026 21:43
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
cristianscheid
force-pushed
the
feat/noid/ocm-new-notifications-provider
branch
from
November 19, 2026 21:44
f2d35b4 to
a431a3a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/ocm/notificationssenderDomainfield:https://github.com/cs3org/OCM-API/blob/v1.5.0/IETF-OCM.md#notifications
https://datatracker.ietf.org/doc/html/draft-ietf-ocm-open-cloud-mesh-07#name-notifications
RequestHandlerController::receiveNotification()checks whether the payload has asenderDomainfield:senderDomainfield: handles it with the new formatsenderDomainfield: handled as beforeTODO
Checklist
3. to review, feature component)stable32)AI (if applicable)