Repository navigation
fix(updater): show the folder in the backup clean-up error - #66624
Open
SKroman108 wants to merge 1 commit into
Open
SKroman108 wants to merge 1 commit into
SKroman108 wants to merge 1 commit into
Conversation
The message was in single quotes, so the log said literally "Could not remove updater backup folder $dir". Signed-off-by: SKroman108 <138336203+SKroman108@users.noreply.github.com>
SKroman108
requested review from
icewind1991 and
provokateurin
and removed request for
a team
November 14, 2026 22:29
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
BackgroundCleanupUpdaterBackupsJob, the error for a backup folder that can't be removed is written in single quotes, so the log shows the literal textCould not remove updater backup folder $dirinstead of the path. Switched it to double quotes, as the neighbouring log lines already use.Checklist
🤖 Generated with Claude Code