Skip to content

[stable31] fix(theming): only accept canonical svg paths for themed icons - #66314

Merged
AndyScherzinger merged 1 commit into
stable31from
backport/66285/stable31
Nov 4, 2026
Merged

AndyScherzinger merged 1 commit into
stable31from
backport/66285/stable31

Conversation

@backportbot

@backportbot backportbot Bot commented Nov 4, 2026

Copy link
Copy Markdown

Backport of PR #66285

The themed icon cache key was derived from the raw image path while the
lookup in Util::getAppImage() strips ".." and tries additional
extensions. This allowed many spellings of the same file (including
non-svg images) to each create a separate cache entry.

Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-VGIZP3VV

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@AndyScherzinger
AndyScherzinger merged commit a6cea8c into stable31 Nov 4, 2026
176 of 189 checks passed
@AndyScherzinger
AndyScherzinger deleted the backport/66285/stable31 branch November 4, 2026 19:38
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked because it has been closed for more than 7 days. As we do not monitor merged or closed pull requests, we are locking this pull request to prevent further comments from getting lost in the noise.
If you discovered any issues with this pull request, please open a new issue instead. In case you want to discuss this pull request or have further questions, please use our forum: https://help.nextcloud.com

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants