Skip to content

fix(dav): expose the share on storages of the legacy public endpoint - #66013

Merged
susnux merged 1 commit into
masterfrom
fix/dav-legacy-public-share-storage
Nov 18, 2026
Merged

susnux merged 1 commit into
masterfrom
fix/dav-legacy-public-share-storage

Conversation

@susnux

@susnux susnux commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Like on the new public endpoint, wrap storages accessed through public.php/webdav with PublicShareWrapper. Otherwise share restrictions and listeners that resolve the share from the storage are not applied there.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@susnux susnux added bug 3. to review Waiting for reviews labels Oct 29, 2026
@susnux
susnux requested a review from a team as a code owner October 29, 2026 15:12
@susnux
susnux requested review from Altahrim, come-nc, icewind1991 and salmart-dev and removed request for a team October 29, 2026 15:12
@susnux susnux added this to the Nextcloud 36 milestone Oct 29, 2026
@susnux

susnux commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable35

@susnux

susnux commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable34

@susnux

susnux commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable33

@susnux
susnux requested review from leftybournes and removed request for salmart-dev October 29, 2026 15:13
@susnux
susnux requested review from GhassenKefi and provokateurin and removed request for icewind1991 November 2, 2026 22:12
Like on the new public endpoint, wrap storages accessed through
`public.php/webdav` with `PublicShareWrapper`. Otherwise share
restrictions and listeners that resolve the share from the storage
(e.g. `ViewOnlyPlugin` or the download handling) are not applied there.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnux force-pushed the fix/dav-legacy-public-share-storage branch from 68a0020 to bb1fb7b Compare November 18, 2026 20:26
@susnux
susnux merged commit 4fc5a2b into master Nov 18, 2026
159 checks passed
@susnux
susnux deleted the fix/dav-legacy-public-share-storage branch November 18, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants