Repository navigation
Conversation
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Assisted-by: Codex:GPT-6 Signed-off-by: Robin Delattre <contact@piedweb.com>
Make the repeated-field workload independently reproducible without accessing instance configuration or vault data, and cover malformed input and key/field boundaries. Assisted-by: Codex:GPT-6 Signed-off-by: Robin Delattre <contact@piedweb.com>
aca97d6 to
2d5ebe9
Compare
Summary
The Passwords app decrypts six fields consecutively with the same key material. Each field currently repeats the same PBKDF2 derivation. Reuse the current derived AES key while its input is unchanged, keeping just one fingerprint per Crypto instance. A different input derives a new key. Ciphertext formats, KDF parameters, per-field IV handling and HMAC checks remain unchanged.
A deployment on Nextcloud 35.0.3 with Passwords 2026.11.20 and PHP 8.5.12 produced these measurements:
password/listresponse, 344 items, median of five Chrome requestsAll five requests before and ten requests after returned HTTP 200. The complete responses after the change matched the baseline response exactly, compared only in browser memory. No vault contents, keys or identifiers were exported. The final after series ran without the synthetic benchmark in parallel; shared-host and network load still vary, so these timings are observations rather than a latency guarantee. Measurements were performed with agent assistance. The contributor has independently tested the deployed change and confirmed that the vault works correctly.
Validation:
tests/benchmarks/crypto.phpreproduces the repeated-field workload without loading instance configuration or accessing a database/vault. Before/after source can be selected in separate processes with the same dependencies; every plaintext is checked. All three runs reproduced 2,064 → 344 derivations for 344 revisions. Seetests/benchmarks/README.mdfor commands and limits.build/autoloaderchecker.shpass.TODO
leftybournesandCarlSchwan; approval still pending.Checklist
stable35after merge intomaster. An eligible collaborator/contributor needs to queue/backport to stable35; the PR author is not eligible to invoke the bot yet.3. to review, feature component) —feedback-requestedis present. Suggested additional triage labels:performance 🚀and3. to review; the author cannot assign repository labels.stable32) — suggested milestone: Nextcloud 36 (master); assignment requires maintainer triage.AI (if applicable)
AI-assisted implementation, tests, benchmarking and documentation. I reviewed the changes and tested them on a live Nextcloud instance.