Repository navigation
Dismiss notifications instantly and smoothen animations - #3573
Merged
Merged
Conversation
kra-mo
approved these changes
Nov 5, 2026
kra-mo
left a comment
kra-mo
left a comment
Member
There was a problem hiding this comment.
Nice, also fixes the issue I mentioned :)
kra-mo
requested changes
Nov 5, 2026
kra-mo
left a comment
kra-mo
left a comment
Member
There was a problem hiding this comment.
Well actually, it seems like a scrollbar appears every time a notification is dismissed? I guess horizontal overflow should be disabled for the view.
Member
|
Review of @Antreesy is mandatory |
jancborchardt
force-pushed
the
fix/dismiss-notification-instantly
branch
from
November 5, 2026 14:41
15ee1a7 to
1a7a632
Compare
Member
Author
@kra-mo good catch, I missed that! Fixed |
kra-mo
approved these changes
Nov 5, 2026
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com> Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Marking the tab as active refreshes the cached notifications. Doing it before the delete request cached the dismissed notifications, so they came back on the next poll. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/dismiss-notification-instantly
branch
from
November 9, 2026 14:00
1a7a632 to
7a67ecb
Compare
Antreesy
approved these changes
Nov 9, 2026
Antreesy
left a comment
Antreesy
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, adjusted some styles and tab leadership (important for fetching order)
The subject text is a flex item, so it could not shrink below the width of a long user name. The name did not get an ellipsis and the notification overflowed the panel. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/dismiss-notification-instantly
branch
from
November 9, 2026 14:18
284dbe8 to
5bfacff
Compare
Collaborator
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
github-project-automation
Bot
moved this from 🏗️ At engineering
to 🎉 Done
in 🖍 Design team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When dismissing a notification via the x button, the animation played only after a short delay, making the interface seem not responsive.
This PR fixes that by optimistically removing dismissed notifications without waiting for server, and restoring them if it fails. Additionally the previously janky animation has been smoothened.
Screencast.From.2026-11-05.15-22-52.webm
Screencast.From.2026-11-05.15-21-21.webm
🤖 AI (if applicable)