Repository navigation
fix(NotificationItem): remove entry and close menu when an app handles a link action - #3572
Open
jancborchardt wants to merge 2 commits into
Open
jancborchardt wants to merge 2 commits into
jancborchardt wants to merge 2 commits into
Conversation
7 of 11 tasks
…s a link action Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/view-chat-close-dropdown
branch
from
November 9, 2026 17:05
064ba5a to
e581c00
Compare
Antreesy
reviewed
Nov 9, 2026
Antreesy
left a comment
Antreesy
left a comment
Collaborator
There was a problem hiding this comment.
Rebased onto master
It's not guaranteed, that intercepted notification is dismissed by the app, so I'd prefer to not remove it.
Kept popup closing on interception, let me know if that's good enough. IMO from the moment you clicked on 'View chat' and acted on it (read the message, replied, e.t.c.), app in question (Talk here) should dismiss the notification on the backend, and notifications app will update the list in the background or when you open the popup next time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 fixes which make the Talk PR look much nicer: nextcloud/spreed#20162
🖼️ Screenshots / Screencasts
Screencast.From.2026-11-05.13-27-24.webm
Screencast.From.2026-11-05.13-21-00.webm
🤖 AI (if applicable)