fix: open custom unified search file results - #4275
Open
Dennis-Otto wants to merge 1 commit into
Open
Conversation
Resolve custom provider entries with standard fileId or path attributes to native Nextcloud file metadata. This avoids creating temporary URL metadata that cannot be selected and preserves the URL fallback for non-file results. Assisted-by: Codex:gpt-5 Signed-off-by: Dennis Otto <61191244+Dennis-Otto@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fileIdorpathattributes to native Nextcloud file metadata.filesandfulltextsearchproviders.Reasoning
Nextcloud iOS currently creates temporary URL metadata for every result from a custom unified search provider, even when the entry exposes the standard
fileIdandpathattributes. Selecting that temporary item exits silently because its randomocIdis not present in Realm.Resolving those attributes before creating the URL fallback makes file-backed results use the regular native file metadata and viewer. It also gives them their actual file type and preview instead of a generic URL icon.
Closes #4274.
Testing
git diff --check.xcrun swiftc -frontend -parse.馃 AI (if applicable)