Skip to content

fix(settings): bind settings dialog open state with v-model for Vue 3 #3577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jay23606 wants to merge 1 commit into
base: master
Choose a base branch
from
+27 −1
Open

fix(settings): bind settings dialog open state with v-model for Vue 3 #3577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Modals/SettingsDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ SPDX-License-Identifier: AGPL-3.0-only OR AGPL-3.0-or-later

<template>
<NcAppSettingsDialog
:open.sync="isOpen"
v-model:open="isOpen"
:name="t('cookbook', 'Cookbook settings')"
:show-navigation="true"
first-selected-section="keyboard shortcuts"
Expand Down
26 changes: 26 additions & 0 deletions tests/check_settings_dialog_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# SPDX-FileCopyrightText: 2026 Nextcloud cookbook contributors
#
# SPDX-License-Identifier: AGPL-3.0-only OR AGPL-3.0-or-later

"""Check that SettingsDialog binds NcAppSettingsDialog's open state with Vue 3 syntax."""

import sys
from pathlib import Path

path = Path(__file__).resolve().parent.parent / "src" / "components" / "Modals" / "SettingsDialog.vue"
text = path.read_text(encoding="utf-8")

if ":open.sync" in text:
print("FAIL: SettingsDialog.vue uses ':open.sync', which Vue 3 ignores; expected 'v-model:open'")
sys.exit(1)

if 'v-model:open="isOpen"' not in text:
print("FAIL: SettingsDialog.vue does not bind 'v-model:open=\"isOpen\"'")
sys.exit(1)

dialog = Path(__file__).resolve().parent.parent / "node_modules" / "@nextcloud" / "vue" / "dist" / "chunks" / "NcAppSettingsDialog.mjs"
if 'emits: ["update:open"]' not in dialog.read_text(encoding="utf-8"):
print("FAIL: NcAppSettingsDialog does not declare the 'update:open' event that v-model:open needs")
sys.exit(1)

print("OK: SettingsDialog.vue binds the open state with v-model:open")