Repository navigation
fix(l10n): "Delete link" and translator context for "Add to team" - #3174
Open
rakekniven wants to merge 2 commits into
Open
rakekniven wants to merge 2 commits into
rakekniven wants to merge 2 commits into
Conversation
- The button deletes the invitation link (revokeInvitationLink) and its confirmation asks to delete the link, so "Reject link" was misleading - Add a TRANSLATORS comment for the "Add to team" menu Reported at Transifex. Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two issues reported at Transifex for resource
circles:CircleConfigInvitationLink.vue): the button callsrevokeInvitationLink(), and its confirmation asks "Do we really want to delete the link?". "Reject" is misleading next to "Create link", "Copy link" and "Reset link". It is now "Delete link".TeamNavigation.vue): translators asked whether someone or something is added. It is the "+" menu that creates a team folder, collective, page or Deck board. The label sat inside the attribute list ofNcActions, where a comment cannot be placed, so it moved into a constant with aTRANSLATORScomment. Same string.One source string changes ("Reject link" → "Delete link"). I could not run the build locally.
🤖 Generated with Claude Code