Skip to content

ci: comment out build check and fix patch name for template sync - #3173

Open
cristianscheid wants to merge 1 commit into
masterfrom
fix/noid/npm-build-patch
Open

cristianscheid wants to merge 1 commit into
masterfrom
fix/noid/npm-build-patch

Conversation

@cristianscheid

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

#2976 commented out the build check in npm-build.yml, but saved the patch as npm-build.patch instead of npm-build.yml.patch.

The workflow sync expect patches to be named like <workflow>.yml.patch (docs), so the patch was ignored and the check was re-enabled by the latest workflow update.

I've regenerated the patch against current template and renamed it to npm-build.yml.patch, so future workflow updates keep the check disabled.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
@cristianscheid

Copy link
Copy Markdown
Member Author

/backport to stable35

@codecov

codecov Bot commented Nov 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@pringelmann

Copy link
Copy Markdown
Contributor

Rename is fine I think, but please keep the build check on for now. Let's maybe fix the workflow first then disable the check.

@cristianscheid

Copy link
Copy Markdown
Member Author

Rename is fine I think, but please keep the build check on for now. Let's maybe fix the workflow first then disable the check.

@pringelmann I'm not sure I understand what you mean by "fix the workflow first then disable the check". Would fixing not be commenting out the "Check build changes" and "Show changes on failure" sections, like was done on the original PR (#2976)?

@pringelmann

Copy link
Copy Markdown
Contributor

Rename is fine I think, but please keep the build check on for now. Let's maybe fix the workflow first then disable the check.

@pringelmann I'm not sure I understand what you mean by "fix the workflow first then disable the check". Would fixing not be commenting out the "Check build changes" and "Show changes on failure" sections, like was done on the original PR (#2976)?

Sorry I was unclear. What I would suggest before we can drop the check:

  • update-node-dist.yml line 83 adds dist/ core/css/, which are server paths. Should be js/ css/. We can fix that in this PR.
  • That workflow has never run successfully, since it fails because BOT_GITHUB_TOKEN is empty.

Until the token is sorted we should keep the check on, otherwise nothing ever rebuilds the assets.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants