Repository navigation
ci: comment out build check and fix patch name for template sync - #3173
cristianscheid wants to merge 1 commit into
Conversation
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
|
/backport to stable35 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Rename is fine I think, but please keep the build check on for now. Let's maybe fix the workflow first then disable the check. |
@pringelmann I'm not sure I understand what you mean by "fix the workflow first then disable the check". Would fixing not be commenting out the "Check build changes" and "Show changes on failure" sections, like was done on the original PR (#2976)? |
Sorry I was unclear. What I would suggest before we can drop the check:
Until the token is sorted we should keep the check on, otherwise nothing ever rebuilds the assets. |
Summary
#2976 commented out the build check in
npm-build.yml, but saved the patch asnpm-build.patchinstead ofnpm-build.yml.patch.The workflow sync expect patches to be named like
<workflow>.yml.patch(docs), so the patch was ignored and the check was re-enabled by the latest workflow update.I've regenerated the patch against current template and renamed it to
npm-build.yml.patch, so future workflow updates keep the check disabled.Checklist
3. to review, feature component)stable32)AI (if applicable)