Fix NIST platform builder for unparseable versions - #890
Open
NataliaPerez08 wants to merge 1 commit into
Open
Conversation
NataliaPerez08
requested review from
itdependsnetworks and
jeffkala
as code owners
August 21, 2026 19:30
Collaborator
|
@NataliaPerez08 thanks for the PR! Quick question. Is the version in the regression test actually coming out of Just curious as the leading zero in the major version field is actually not following semver: https://semver.org/spec/v2.0.0.html#spec-item-2 Trying to ensure that this isn't a "made up failure" vs an actual bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #861
version_metadata()may return a dictionary containing keys that are notdefined on the dynamically generated platform dataclass when a version cannot
be parsed.
This change filters the returned metadata to fields defined by the platform
dataclass before constructing the object.
A regression test was added for the Cisco IOS version
03.03.05SE.Tests: