Use ConfigResolverInterface instead of the removed ConfigResolver - #60
Merged
Merged
Conversation
Member
Author
|
@emodric I'm not sure how to resolve the phpstan issue, any ideas? Should I remove the composer.json change which locks to ^5.0.10, which is the release that introduced the removal of ConfigResolver? I would assume it should work with prior ^5.0 versions of ibexa/core, as well, though, so perhaps it would be fine without that change |
Member
Author
|
Changed tests to require symfony 7.4 per discussions - ibexa/core 5.0.10 is necessary because prior releases do not have the consts on the interface The currently failing test is not related to this change, not sure what to do about it |
Member
|
Thanks @amalija-ramljak |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference for removal - ibexa/core#764
https://netgen.atlassian.net/browse/NGSTACK-1057
Changed from ConfigResolver, which was removed in ibexa core v5.0.10, to ConfigResolverInterface - and bumped composer ibexa/core version to include the .10 minor if it's necessary
Issue was found during attempted installation of the netgen/media-site template