Repository navigation
Keep CompoundSpan off splice opcodes (depends on #4740 and neo-vm#592) - #4742
Closed
cschuchardt88 wants to merge 6 commits into
Closed
cschuchardt88 wants to merge 6 commits into
cschuchardt88 wants to merge 6 commits into
Conversation
ApplicationEngine.LimitsFor sets SafeSubStr (Echidna) and StrictContainerAccess/BoundedShift (Gorgon). SUBSTR/SHL/SHR/HASKEY overlays are removed; PICKITEM/SETITEM/REMOVE stay pre-Gorgon until those land in neo-vm. Uses a sibling ProjectReference to the neo-vm fork until a Neo.VM package with VmFeatures is published.
CI and the upstream repo cannot use a sibling ProjectReference to a local neo-vm checkout.
HF_Echidna enables SafeSubStr; HF_Gorgon enables StrictContainerAccess and BoundedShift. LimitsFor starts from None so pre-fork heights keep the old opcode paths.
Companion to neo-vm#594. LimitsFor does not set CompoundSpan, so CAT/SUBSTR of Map/Array/Struct still FAULT. Host GetSafeSpan/AsSpan stay available without changing opcode behavior.
Match neo-vm: the engine always passes the RET-coalesced instruction, so diagnostics do not need a null check.
This was referenced Aug 28, 2026
cschuchardt88
changed the title
3 of 11 tasks
12 of 41 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Companion to neo-project/neo-vm#594 (depends on #4740 and neo-vm#592).
Related: neo-project/proposals#235 (compound binary / CAT on compounds).
ApplicationEngine.LimitsFordoes not mapVmFeatures.CompoundSpanfrom a hardfork.CAT/SUBSTR/LEFT/RIGHT/MEMCPYof Map/Array/Struct still FAULT. HostGetSafeSpan/AsSpanstay available without changing opcode behavior.Change Log
CompoundSpanas host-only onLimitsForCATof empty Map FAULTSFixes # (issue)
Type of change
How Has This Been Tested?
Checklist:
Status
Draft. CI cannot compile
VmFeaturesuntil neo-vm#592/#594 are in a publishedNeo.VMpackage. Includes #4740 commits until that lands.