Repository navigation
Conversation
Port two commits from LekoArts/gatsby-starter-portfolio-emilia: - ef90ad7: gatsby ^5.14.3, @types/node ^22.15.3, @types/react ^18.3.20, @types/react-dom ^18.3.7, typescript ^5.8.3 - 616037c: version 0.3.17, gatsby ^5.14.5, @types/node ^22.15.33, CHANGELOG entry for 0.3.17 package-lock.json regenerated with npm install. yarn.lock left unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MDX parses <span style="color: red;"> as JSX, and React rejects a
string style prop, so building static HTML for "/" failed (seen in CI
run 37270173414 on ubuntu). Use style={{color: "red"}} instead. The
rendered HTML is unchanged: <span style="color:red">.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- .nvmrc: 18 -> 22.23.3. Node 18 and 20 are past end of life; Node 22 ships npm 10, which runs the install scripts sharp and lmdb need. Verified locally on darwin-arm64: npm ci, then two builds from an empty cache, both succeeded. - CI: read the Node version from .nvmrc, use npm ci instead of npm install, update actions to v4, let all OS jobs finish (fail-fast: false), and deploy only from the ubuntu job. - README: document the pinned version and that x64 Node under Rosetta segfaults in gatsby build on Apple Silicon. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
20261005merge did not deploy, because the build failed on the ubuntu CI job (run 37270173414). This PR fixes that failure and sets CI to the Node version tested locally.Changes
about-me.mdxhad<span style="color: red;">. MDX reads this as JSX, and React rejects a stringstylevalue, so building the HTML for/failed. It is nowstyle={{color: "red"}}, and the output HTML is still<span style="color:red">..nvmrcchanges from 18 to 22.23.3, and CI reads the Node version from that file.npm ciinstead ofnpm install, so it installs the versions in package-lock.json.Testing
npm ciandnpm run buildpassed twice, starting with no.cacheeach time.🤖 Generated with Claude Code