Repository navigation
Conversation
myc-yang
force-pushed
the
166-useless-variable-assigments
branch
from
September 10, 2026 19:08
f5c6cab to
222d2fc
Compare
myc-yang
marked this pull request as draft
September 14, 2026 13:28
myc-yang
force-pushed
the
166-useless-variable-assigments
branch
from
September 14, 2026 17:16
8d04234 to
c1b2920
Compare
myc-yang
marked this pull request as ready for review
September 14, 2026 17:26
jphickey
requested changes
Sep 15, 2026
|
|
||
| /* Get start of linked list (all MID's with same hash result) */ | ||
| HashLink = DS_AppData.HashTable[HashTableIndex]; | ||
| DS_HashLink_t *HashLink = DS_AppData.HashTable[HashTableIndex]; |
Contributor
There was a problem hiding this comment.
Can we keep these as separate declarations and assignments?
Try to avoid mixing declarations and logic.
Just remove the assignments on the original declarations, and keep the assignments where they were.
myc-yang
force-pushed
the
166-useless-variable-assigments
branch
from
September 15, 2026 15:06
c1b2920 to
9e1a3e4
Compare
…static code analysis
myc-yang
force-pushed
the
166-useless-variable-assigments
branch
from
September 16, 2026 11:16
9e1a3e4 to
59dbc19
Compare
myc-yang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For members of the cFS Team
Click the
Previewtab and select the pull request template corresponding to the type of change you are submitting:Checklist (Please check before submitting)
Describe the contribution
Fixes #166
Testing performed
Static code analysis and Unit Tests
Expected behavior changes
No impact to behavior
System(s) tested on
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
Michael Yang / NASA/GSFC