Repository navigation
fix(sync): preserve startup debug reports - #1771
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix missing startup debug reports after
/reloadand when Continuous sync is enabled, without changing model context or sync authorization.debugat session start even when Continuous sync is initially Off or no setup exists, and suppress stale reports after cancellation, replacement, or shutdown.@narumitw/pi-sync.Verification
npm run checkpassed: builds, Biome, package boundaries, and workspace typechecks.npm testpassed: 17,548 tests passed and 15 skipped.npm run package:pack -- syncpassed; the actual 307-file archive contains the entrypoint, lazy chunks, renderer, and documentation, with no private state, tests, ornode_modules.origin/main;git rebase origin/maincompleted without conflicts. Pre-commit checks andgit diff --checkpassed.Audit and limits
Reviewed the touched areas against
docs/extension-conventions.md,docs/extension-settings.md, anddocs/readme-conventions.md, including lifecycle ownership, cancellation, settings activation, terminal controls and width bounds, and model-context exclusion. The complete debug-activation class includes initially enabled, initially disabled, and empty setup catalogs.Physical-terminal visual acceptance and production storage/provider behavior remain unverified. No installed user package, personal settings, publication, visibility, tag, or release workflow was changed. Evidence is retained in
packages/pi-sync/docs/continuous-sync-verification.md.