Skip to content

fix(sync): preserve startup debug reports - #1771

Merged
narumiruna merged 1 commit into
mainfrom
narumi/fix/sync-startup-debug
Nov 1, 2026
Merged

narumiruna merged 1 commit into
mainfrom
narumi/fix/sync-startup-debug

Conversation

@narumiruna

Copy link
Copy Markdown
Owner

Summary

Fix missing startup debug reports after /reload and when Continuous sync is enabled, without changing model context or sync authorization.

  • Store TUI timing reports as native custom session entries so later info notifications cannot replace them; preserve RPC notifications and silent print/JSON behavior.
  • Report the initial Continuous sync cycle, including nested transfer stages, without repeating reports on later polls or idle resumes.
  • Capture debug at session start even when Continuous sync is initially Off or no setup exists, and suppress stale reports after cancellation, replacement, or shutdown.
  • Add regression tests, update package guidance, and include a patch Changeset for @narumitw/pi-sync.

Verification

  • npm run check passed: builds, Biome, package boundaries, and workspace typechecks.
  • npm test passed: 17,548 tests passed and 15 skipped.
  • After rebase: 139 focused regression tests passed across eight files.
  • Built package-directory RPC smoke passed against conditional loopback WebDAV: exactly two startup timing reports, zero model requests, later automatic publication, and released ownership.
  • npm run package:pack -- sync passed; the actual 307-file archive contains the entrypoint, lazy chunks, renderer, and documentation, with no private state, tests, or node_modules.
  • Fenced-code-aware README heading audit passed across 37 packages.
  • The base already matched origin/main; git rebase origin/main completed without conflicts. Pre-commit checks and git diff --check passed.

Audit and limits

Reviewed the touched areas against docs/extension-conventions.md, docs/extension-settings.md, and docs/readme-conventions.md, including lifecycle ownership, cancellation, settings activation, terminal controls and width bounds, and model-context exclusion. The complete debug-activation class includes initially enabled, initially disabled, and empty setup catalogs.

Physical-terminal visual acceptance and production storage/provider behavior remain unverified. No installed user package, personal settings, publication, visibility, tag, or release workflow was changed. Evidence is retained in packages/pi-sync/docs/continuous-sync-verification.md.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T17:42:45.089522Z 3bf3525 PR opened
🔒 Security Review ✅ Completed 2026-11-01T17:43:27.930443Z 3bf3525 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@narumiruna
narumiruna merged commit b4aa010 into main Nov 1, 2026
1 check passed
@narumiruna
narumiruna deleted the narumi/fix/sync-startup-debug branch November 1, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant