Repository navigation
Fix IPv6 prefix masks in network and containment functions - #171
Merged
Merged
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ipnetwork()retains host bits in IPv6 addresses because the boundary-byte mask complements the prefix remainder instead of preserving its high bits. For example, the address from #170 with/64produces2001:db8:1111:2222:3300::/64instead of2001:db8:1111:2222::/64.Apply the correct mask in both
ipnetwork()andipcontains(), which uses the same calculation on its two operands. Includes SQL regressions for byte boundaries, every partial-byte mask,/0,/128, and subnet containment. Fixes #170.Validation on Linux ARM64:
ipaddresspass for both standalone and bundled extensions, covering all IPv6/IPv4 prefix lengths.Windows and macOS were not tested locally. Developed and tested with OpenAI Codex.