chore: upgrade to NPM v12 - #24
Merged
Merged
Conversation
Require npm >=12.0.2 <13, enforced via check-node-version on npm install and npm ci. CI installs the version from engines.npm via the new .github/actions/install-npm composite action. The motivation is that npm v12 turns three code-execution paths off by default, most notably the unauthorized execution of install scripts: - allowScripts now defaults to off, so npm install no longer executes preinstall, install or postinstall scripts from dependencies unless they are explicitly allowed in package.json. This also covers prepare scripts from git, file and link dependencies. - --allow-git now defaults to none, which closes a code-execution path where a git dependency's .npmrc could override the git executable, even with --ignore-scripts. - --allow-remote now defaults to none, blocking dependencies from remote URLs such as HTTPS tarballs. See https://github.blog/changelog/2026-06-09-upcoming-breaking-changes-for-npm-v12/ The check is skipped during npm publish and npm pack, because semantic-release bundles its own npm (@semantic-release/npm depends on npm@^11.6.2) and runs the publish with that version rather than the one installed in CI. The Node.js requirement is left unchanged.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7ab1f8f. Configure here.
| "scripts": { | ||
| "test": "node --no-warnings --experimental-transform-types --test \"./*.spec.ts\"" | ||
| "test": "node --no-warnings --experimental-transform-types --test \"./*.spec.ts\"", | ||
| "prepare": "case \"$npm_command\" in install|ci) check-node-version --package ;; esac" |
There was a problem hiding this comment.
Prepare script breaks Windows
Medium Severity
The new prepare script uses POSIX case/esac syntax. On Windows, npm runs lifecycle scripts with cmd.exe by default, which does not understand that syntax, so npm install and npm ci fail when prepare runs.
Reviewed by Cursor Bugbot for commit 7ab1f8f. Configure here.
Member
Author
|
Security fix, no review required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Require npm
>=12.0.2 <13for this project. The Node.js requirement is left unchanged. It is enforced viacheck-node-versiononnpm installandnpm ci.Why
npm v12 turns three code-execution paths off by default — most notably the
unauthorized execution of install scripts, which is the primary vector for
supply-chain attacks via compromised dependencies
(GitHub changelog):
allowScriptsnow defaults to off, sonpm installno longer executespreinstall,installorpostinstallscripts from dependencies unless theyare explicitly allowed in
package.json. This also coverspreparescriptsfrom
git,fileandlinkdependencies.--allow-gitnow defaults tonone, which closes a code-execution pathwhere a git dependency's
.npmrccould override the git executable, even with--ignore-scripts.--allow-remotenow defaults tonone, blocking dependencies from remoteURLs such as HTTPS tarballs.
Pinning
engines.npmto>=12.0.2 <13and failing the install when it is notmet means these protections cannot be silently bypassed by running an older npm
locally or in CI.
How
engines.npmis set to>=12.0.2 <13.engines.nodeis left untouched.check-node-version --packageruns from thepreparescript, which npmexecutes on
npm installandnpm ci.engines.npmthrough the new.github/actions/install-npmcomposite action, added after eachactions/setup-nodestep.The check is skipped during
npm publishandnpm pack, becausesemantic-releasebundles its own npm (@semantic-release/npmdepends onnpm@^11.6.2) and runs the publish with that version rather than the one installed in CI.